Skip to content

Conversation

@miaulalala
Copy link
Contributor

  • Resolves: #

Summary

Unsharing a group share should also be possible for Circle group shares

TODO

  • ...

Checklist

@miaulalala miaulalala added the 3. to review Waiting for reviews label Sep 4, 2024
@miaulalala miaulalala self-assigned this Sep 4, 2024
@miaulalala
Copy link
Contributor Author

/backport to stable30

@miaulalala
Copy link
Contributor Author

/backport to stable29

@miaulalala
Copy link
Contributor Author

/backport to stable28

@kesselb
Copy link
Contributor

kesselb commented Sep 4, 2024

LGTM 👍

Commit message needs an update

@miaulalala miaulalala force-pushed the fix/also-allow-unsharing-for-circles branch from 341ee6b to 3355b20 Compare September 5, 2024 15:58
@miaulalala miaulalala force-pushed the fix/also-allow-unsharing-for-circles branch from 3355b20 to 17ef20c Compare September 5, 2024 19:34
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but didn't test.

@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 10, 2024
@st3iny st3iny added this to the Nextcloud 31 milestone Sep 10, 2024
@st3iny st3iny merged commit 5afe212 into master Sep 10, 2024
@st3iny st3iny deleted the fix/also-allow-unsharing-for-circles branch September 10, 2024 05:42
@st3iny st3iny added bug feature: caldav Related to CalDAV internals feature: carddav Related to CardDAV internals labels Sep 10, 2024
@backportbot
Copy link

backportbot bot commented Sep 10, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/47737/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 17ef20c5

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47737/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link

backportbot bot commented Sep 10, 2024

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/47737/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 17ef20c5

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47737/stable29

Error: Failed to push branch backport/47737/stable29: fatal: could not read Username for 'https://github.com': No such device or address


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

kesselb added a commit that referenced this pull request Apr 8, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- #43117
- #47737

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request Apr 8, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- #43117
- #47737

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request Apr 8, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- #43117
- #47737

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request Apr 8, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- #43117
- #47737

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request Apr 8, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- #43117
- #47737

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request Apr 8, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- #43117
- #47737

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request Apr 9, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- #43117
- #47737

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request Apr 11, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- #43117
- #47737

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request Apr 11, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- #43117
- #47737

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request Apr 14, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- #43117
- #47737

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request Apr 15, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- #43117
- #47737

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request Apr 15, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- #43117
- #47737

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request Apr 15, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- #43117
- #47737

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request May 9, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- #43117
- #47737

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request May 14, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- #43117
- #47737

Signed-off-by: Daniel Kesselberg <[email protected]>
backportbot bot pushed a commit that referenced this pull request May 14, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- #43117
- #47737

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request May 15, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- #43117
- #47737

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request May 15, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- #43117
- #47737

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request May 16, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- #43117
- #47737

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request May 19, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- #43117
- #47737

Signed-off-by: Daniel Kesselberg <[email protected]>
backportbot bot pushed a commit that referenced this pull request May 19, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- #43117
- #47737

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request May 20, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- #43117
- #47737

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request May 20, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- #43117
- #47737

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request May 20, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- #43117
- #47737

Signed-off-by: Daniel Kesselberg <[email protected]>
mickenordin pushed a commit to mickenordin/server that referenced this pull request May 23, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- nextcloud#43117
- nextcloud#47737

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request Jun 1, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- #43117
- #47737

Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb added a commit that referenced this pull request Jun 1, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- #43117
- #47737

Signed-off-by: Daniel Kesselberg <[email protected]>
AIlkiv pushed a commit to AIlkiv/server that referenced this pull request Jul 10, 2025
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.

Related PRs:
- nextcloud#43117
- nextcloud#47737

Signed-off-by: Daniel Kesselberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish backport-request bug feature: caldav Related to CalDAV internals feature: carddav Related to CardDAV internals

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

5 participants