Skip to content

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 4, 2024

If file doesn't exist, the Sidebar is not mounted, so refs.sidebar is undefined

<NcAppSidebar v-if="file"
ref="sidebar"

@skjnldsv skjnldsv added bug 3. to review Waiting for reviews feature: files feature: file sidebar Related to the file sidebar component labels Sep 4, 2024
@skjnldsv skjnldsv requested review from a team and blizzz September 4, 2024 12:12
@skjnldsv skjnldsv self-assigned this Sep 4, 2024
@skjnldsv skjnldsv requested review from Pytal, susnux and szaimen and removed request for a team September 4, 2024 12:12
@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 4, 2024

/backport to stable30

@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 4, 2024

/backport to stable29

@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 4, 2024

/backport to stable28

@susnux
Copy link
Contributor

susnux commented Sep 4, 2024

/compile

Signed-off-by: nextcloud-command <[email protected]>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 4, 2024
@skjnldsv skjnldsv merged commit 2d2a510 into master Sep 4, 2024
@skjnldsv skjnldsv deleted the fix/sidebar-undefined branch September 4, 2024 14:50
@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 4, 2024

/backport to stable29

@backportbot

This comment was marked as resolved.

@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: file sidebar Related to the file sidebar component feature: files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants