Skip to content

Conversation

@SystemKeeper
Copy link
Contributor

@SystemKeeper SystemKeeper commented Sep 4, 2024

Summary

Currently caching of appstore files is disabled as soon as we are running beta, daily or git channel. When we run the current master and open index.php/settings/apps/discover we hit

/**
* Returns the array with the entries on the appstore server
*
* @param bool [$allowUnstable] Allow unstable releases
* @return array
*/
public function get($allowUnstable = false) {
already 5 times, resulting in 5 requests to apps.json from the app store.

While it makes sense to have a shorter cache time for dev instances, we shouldn't omit all caching. This PR adds a 15 min caching (instead of 60 min on production) to dev instances.

Checklist

@SystemKeeper SystemKeeper self-assigned this Sep 4, 2024
@SystemKeeper SystemKeeper force-pushed the fix/noid/cache-appstore-on-dev-instances branch from 39b37d8 to b2c2c93 Compare September 4, 2024 19:57
@SystemKeeper
Copy link
Contributor Author

/backport! to stable30

@SystemKeeper
Copy link
Contributor Author

/backport! to stable29

@SystemKeeper
Copy link
Contributor Author

/backport! to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants