Skip to content

chore: adjust code to adhere to coding standard #47789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miaulalala merged 2 commits into from
Sep 5, 2024
Merged

chore: adjust code to adhere to coding standard #47789

miaulalala merged 2 commits into from
Sep 5, 2024

Conversation

@miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Sep 5, 2024

  • Resolves: #

Summary

New coding standard fixes

Checklist

@miaulalala miaulalala added 3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Sep 5, 2024
@miaulalala miaulalala requested review from blizzz and kesselb September 5, 2024 19:25
@miaulalala miaulalala self-assigned this Sep 5, 2024
blizzz
blizzz approved these changes Sep 5, 2024
View reviewed changes
apps/user_ldap/lib/Connection.php
foreach (['ldapExpertUUIDUserAttr' => 'ldapUuidUserAttribute',
'ldapExpertUUIDGroupAttr' => 'ldapUuidGroupAttribute']
as $expertSetting => $effectiveSetting) {
'ldapExpertUUIDGroupAttr' => 'ldapUuidGroupAttribute'] as $expertSetting => $effectiveSetting) {
Copy link
Member

@blizzz blizzz Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks a bit funny

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 5, 2024
View reviewed changes
apps/dav/lib/CalDAV/CalendarHome.php
if ($this->caldavBackend instanceof CalDavBackend) {
$calendar = $this->caldavBackend->getCalendarByUri($this->principalInfo['uri'], $name);
if(!empty($calendar)) {
if (!empty($calendar)) {

Check notice

Code scanning / Psalm

RiskyTruthyFalsyComparison

Operand of type array<array-key, mixed>|null contains type array<array-key, mixed>, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead.
apps/dav/lib/CalDAV/EventComparisonService.php

$oldEventComponents = $old->getComponents();
if(is_array($oldEventComponents) && !empty($oldEventComponents)) {
if (is_array($oldEventComponents) && !empty($oldEventComponents)) {

Check notice

Code scanning / Psalm

RedundantConditionGivenDocblockType

Docblock-defined type array<array-key, mixed> for $oldEventComponents is always array<array-key, mixed>
apps/dav/lib/CalDAV/Schedule/IMipPlugin.php
// No changed events after all - this shouldn't happen if there is significant change yet here we are
// The scheduling status is debatable
if(empty($vEvent)) {
if (empty($vEvent)) {

Check notice

Code scanning / Psalm

DocblockTypeContradiction

Operand of type false is always falsy
apps/dav/lib/CalDAV/Schedule/IMipPlugin.php
// No changed events after all - this shouldn't happen if there is significant change yet here we are
// The scheduling status is debatable
if(empty($vEvent)) {
if (empty($vEvent)) {

Check notice

Code scanning / Psalm

DocblockTypeContradiction

Docblock-defined type Sabre\VObject\Component\VEvent for $vEvent is never falsy
apps/dav/lib/CalDAV/Schedule/IMipService.php
/** @var Parameter $partstat */
$partstat = $organizer['PARTSTAT'];
if(strcasecmp($partstat->getValue(), 'ACCEPTED') === 0) {
if (strcasecmp($partstat->getValue(), 'ACCEPTED') === 0) {

Check notice

Code scanning / Psalm

PossiblyNullArgument

Argument 1 of strcasecmp cannot be null, possibly null value provided
apps/dav/lib/CalDAV/Status/StatusService.php
/** @var DateTimeImmutable $dateTime */
$dateTime = $component['DTSTART'][0];
if($dateTime instanceof DateTimeImmutable && $userStatusTimestamp > $dateTime->getTimestamp()) {
if ($dateTime instanceof DateTimeImmutable && $userStatusTimestamp > $dateTime->getTimestamp()) {

Check notice

Code scanning / Psalm

RedundantConditionGivenDocblockType

Docblock-defined type DateTimeImmutable for $dateTime is always DateTimeImmutable
apps/dav/lib/DAV/Sharing/Backend.php

// Don't add share for owner
if($shareable->getOwner() !== null && strcasecmp($shareable->getOwner(), $principal) === 0) {
if ($shareable->getOwner() !== null && strcasecmp($shareable->getOwner(), $principal) === 0) {

Check notice

Code scanning / Psalm

PossiblyNullArgument

Argument 1 of strcasecmp cannot be null, possibly null value provided
apps/dav/lib/DAV/Sharing/Backend.php

// Don't add unshare for owner
if($shareable->getOwner() !== null && strcasecmp($shareable->getOwner(), $principal) === 0) {
if ($shareable->getOwner() !== null && strcasecmp($shareable->getOwner(), $principal) === 0) {

Check notice

Code scanning / Psalm

PossiblyNullArgument

Argument 1 of strcasecmp cannot be null, possibly null value provided
apps/user_status/lib/Service/StatusService.php
}
// If there is a custom message, don't overwrite it
if(empty($status->getCustomMessage())) {
if (empty($status->getCustomMessage())) {

Check notice

Code scanning / Psalm

RiskyTruthyFalsyComparison

Operand of type null|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead.
apps/user_status/lib/Service/StatusService.php
$status->setCustomMessage($predefinedMessage['message']);
}
if(empty($status->getCustomIcon())) {
if (empty($status->getCustomIcon())) {

Check notice

Code scanning / Psalm

RiskyTruthyFalsyComparison

Operand of type null|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead.
@miaulalala miaulalala marked this pull request as ready for review September 5, 2024 20:01
@miaulalala miaulalala merged commit 9aafc0f into master Sep 5, 2024
@miaulalala miaulalala deleted the fix/cs-fixer-errors branch September 5, 2024 20:25
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@blizzz blizzz blizzz approved these changes

@kesselb kesselb kesselb approved these changes

@provokateurin provokateurin provokateurin approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen nickvergessen is a code owner

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

Assignees

@miaulalala miaulalala

Labels

3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@miaulalala @susnux @blizzz @kesselb @provokateurin