fix: Replace conflicting tags in xml_exception template
#47805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
a team,
ArtificialOwl,
artonge and
sorbaugh
and removed request for
a team
provokateurin
approved these changes
Sep 6, 2024
susnux
force-pushed
the
fix/xml-exception-template
branch
from
6a738b1 to
e5745d7
Compare
Contributor
Author
|
/backport to stable29 |
Contributor
Author
|
/backport to stable30 |
2 tasks
artonge
approved these changes
Sep 9, 2024
Antreesy
approved these changes
Sep 9, 2024
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Just stumbled on it, when tried to upload files via Talk (failed on PROPFIND request)
Tested, works with this change
The `<?xml` tag is interpreted as PHP short tags, so this causes errors. Instead just print that part of the template. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/xml-exception-template
branch
from
923850b to
6198138
Compare
This was referenced Sep 9, 2024
8 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
<?xmltag is interpreted as PHP short tags, so this causes errors. Instead just print that part of the template.Checklist