Skip to content

fix(appstore): return if appstore is manually disabled #47834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 2 commits into from
Sep 10, 2024
Merged

fix(appstore): return if appstore is manually disabled #47834

skjnldsv merged 2 commits into from
Sep 10, 2024

Conversation

@solracsf
Copy link
Member

@solracsf solracsf commented Sep 9, 2024

Checklist

@solracsf solracsf added the 3. to review Waiting for reviews label Sep 9, 2024
@solracsf solracsf added this to the Nextcloud 31 milestone Sep 9, 2024
@solracsf
Copy link
Member Author

solracsf commented Sep 9, 2024

/backport to stable30

@solracsf
Copy link
Member Author

solracsf commented Sep 9, 2024

/backport to stable29

@solracsf
Copy link
Member Author

solracsf commented Sep 9, 2024

/backport to stable28

@solracsf solracsf force-pushed the retAppsManDis branch 2 times, most recently from f6a0a38 to e64894d Compare September 9, 2024 07:46
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 9, 2024
View reviewed changes
@solracsf
fix(appstore): return if appstore is manually disabled
2ac8d9a 
Signed-off-by: Git'Fellow <[email protected]>

fix: camel case

Signed-off-by: Git'Fellow <[email protected]>

fix: log a debug log

Signed-off-by: Git'Fellow <[email protected]>

fix: typing

Signed-off-by: Git'Fellow <[email protected]>

fix: typo

fix: typing
@susnux susnux requested review from a team, icewind1991 and nfebe and removed request for a team and nickvergessen September 9, 2024 14:47
nickvergessen
nickvergessen approved these changes Sep 10, 2024
View reviewed changes
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 10, 2024
@skjnldsv skjnldsv enabled auto-merge September 10, 2024 14:01
@skjnldsv skjnldsv merged commit 0858ff7 into master Sep 10, 2024
@skjnldsv skjnldsv deleted the retAppsManDis branch September 10, 2024 14:31
@backportbot backportbot bot mentioned this pull request Sep 10, 2024
Merged
This was referenced Sep 10, 2024
Merged
Merged
@ShGKme ShGKme mentioned this pull request Sep 17, 2024
Merged
4 tasks
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

[Bug]: set 'appstoreenabled' => false, still show Warning logging

5 participants

@solracsf @nickvergessen @susnux @skjnldsv