Skip to content

fix(appstore): Ensure returned apps from AppStore are valid #47854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
solracsf merged 2 commits into from
Sep 13, 2024
Merged

fix(appstore): Ensure returned apps from AppStore are valid #47854

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8585b05
fix(appstore): Ensure returned apps from AppStore are valid
solracsf Sep 9, 2024
dccfb6d
fix: check if key is set
solracsf Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/private/App/AppStore/Fetcher/AppFetcher.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ protected function fetch($ETag, $content, $allowUnstable = false) {
/** @var mixed[] $response */
$response = parent::fetch($ETag, $content);

if (empty($response)) {
if (empty($response) || $response['data'] === null) {
$this->logger->warning('Response from appstore is invalid, apps could not be retrieved. Try again later.', ['app' => 'appstoreFetcher']);
return [];
}

Expand Down