feat(caldav): create subscriptions via occ #47916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaulalala
requested review from
Altahrim,
ChristophWurst,
kesselb and
tcitworld
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ChristophWurst
requested changes
Sep 12, 2024
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Inject the CalDavBackend to get rid of all the service locators
Altahrim
approved these changes
Sep 12, 2024
tcitworld
reviewed
Sep 12, 2024
Member
tcitworld
left a comment
tcitworld
left a comment
There was a problem hiding this comment.
Could be nice to execute subscription sync to test is the URL is valid?
Contributor
Author
I did have that initially, but since it's quite a lot of code duplication I desisted from doing that as it's not really neccessary. The RefreshWebCal Job will log if the url isn't valid. |
Signed-off-by: Anna Larch <[email protected]>
miaulalala
force-pushed
the
feat/add-subscription-via-occ
branch
from
e36071d to
1f00cef
Compare
miaulalala
added
the
pending documentation
This was referenced Oct 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow adding subscriptions via OCC
TODO
Checklist