Skip to content

Conversation

@joshtrichards
Copy link
Member

Summary

Fixes rest of #34720

See #34720 (comment)

Any timeout value is somewhat arbitrary. We're currently using 10s. Lowered to 3s for now.

Might be worth backporting to 30 just to more feedback from real world usage sooner, but otherwise probably doesn't matter at the moment.

TODO

Checklist

Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense :shipit:

@nickvergessen
Copy link
Member

@nickvergessen
Copy link
Member

I mean we can still reduce the seconds, but at least the memory problem is solved?

@joshtrichards
Copy link
Member Author

I mean we can still reduce the seconds, but at least the memory problem is solved?

Correct. Memory usage already addressed. Just dealing with the timeouts now so we can close that issue out entirely.

@skjnldsv
Copy link
Member

We close or we merge then @joshtrichards ? :)

@nickvergessen nickvergessen merged commit 932d488 into master Sep 16, 2024
@nickvergessen nickvergessen deleted the fix/issue-34720 branch September 16, 2024 09:25
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: references/resolved endoint runs into memory exhausted when targeted at big files

5 participants