Skip to content

fix(files_external): Check key exists before accessing it #47968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Sep 14, 2024
Merged

fix(files_external): Check key exists before accessing it #47968

skjnldsv merged 1 commit into from
Sep 14, 2024

Conversation

@solracsf
Copy link
Member

@solracsf solracsf commented Sep 14, 2024

Checklist

@solracsf solracsf added this to the Nextcloud 31 milestone Sep 14, 2024
@solracsf
Copy link
Member Author

solracsf commented Sep 14, 2024

/backport to stable30

@solracsf
Copy link
Member Author

solracsf commented Sep 14, 2024

/backport to stable29

@solracsf
Copy link
Member Author

solracsf commented Sep 14, 2024

/backport to stable28

@skjnldsv skjnldsv requested review from a team, Altahrim, ArtificialOwl and yemkareems and removed request for a team September 14, 2024 16:52
@skjnldsv skjnldsv enabled auto-merge September 14, 2024 16:53
miaulalala
miaulalala approved these changes Sep 14, 2024
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@skjnldsv skjnldsv merged commit 34d07fe into master Sep 14, 2024
@skjnldsv skjnldsv deleted the fixKeyExFileExt branch September 14, 2024 16:53
This was referenced Sep 14, 2024
Merged
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miaulalala miaulalala miaulalala approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: external storage

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

[Bug]: Error: Undefined array key "size" at /var/www/nextcloud/apps/files_external/lib/Lib/Storage/SFTP.php#460

4 participants

@solracsf @miaulalala @skjnldsv