Skip to content

fix(BaseResponse): Cast XML element values to string #48013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
provokateurin merged 1 commit into from
Sep 15, 2024
Merged

fix(BaseResponse): Cast XML element values to string #48013

provokateurin merged 1 commit into from
Sep 15, 2024

Conversation

@provokateurin
Copy link
Member

@provokateurin provokateurin commented Sep 15, 2024 •
edited
Loading

For reference: #47984

Summary

writeElement() only accepts ?string, so we need to cast it explicitly as it will fail with strict types enforced.

Checklist

@provokateurin provokateurin added this to the Nextcloud 31 milestone Sep 15, 2024
@provokateurin provokateurin requested review from a team, ArtificialOwl, artonge, come-nc and miaulalala and removed request for a team September 15, 2024 13:20
@provokateurin
Copy link
Member Author

provokateurin commented Sep 15, 2024

/backport to stable30

@provokateurin
Copy link
Member Author

provokateurin commented Sep 15, 2024

/backport to stable29

@provokateurin
Copy link
Member Author

provokateurin commented Sep 15, 2024

/backport to stable28

@provokateurin provokateurin force-pushed the fix/baseresponse/xml-element-value-string-cast branch from ec7fcce to 3d9b498 Compare September 15, 2024 13:37
@provokateurin provokateurin merged commit 1018912 into master Sep 15, 2024
@provokateurin provokateurin deleted the fix/baseresponse/xml-element-value-string-cast branch September 15, 2024 17:15
This was referenced Sep 15, 2024
Merged
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miaulalala miaulalala miaulalala approved these changes

@sorbaugh sorbaugh sorbaugh approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@artonge artonge Awaiting requested review from artonge artonge is a code owner automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc come-nc is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

4 participants

@provokateurin @miaulalala @sorbaugh