Skip to content

[stable30] fix(Tags): Return boolean for userHasTags() #48027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
provokateurin merged 1 commit into from
Sep 15, 2024
Merged

[stable30] fix(Tags): Return boolean for userHasTags() #48027

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(Tags): Return boolean for userHasTags() 
Signed-off-by: provokateurin <[email protected]>
  • Loading branch information
@provokateurin @backportbot
provokateurin authored and backportbot[bot] committed Sep 15, 2024
commit dd7fb609918862ccef6fc9201f871523cf0b0cbd
3 changes: 1 addition & 2 deletions lib/private/Tags.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,8 +248,7 @@ public function getIdsForTag($tag) {
* @param string $user The user whose tags are to be checked.
*/
public function userHasTag(string $name, string $user): bool {
$key = $this->array_searchi($name, $this->getTagsForUser($user));
return ($key !== false) ? $this->tags[$key]->getId() : false;
return $this->array_searchi($name, $this->getTagsForUser($user)) !== false;
}

/**
Expand Down