Skip to content

[stable28] fix(config): Add missing handling for envCache in getKeys() #48099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icewind1991 merged 3 commits into from
Sep 23, 2024
Merged

[stable28] fix(config): Add missing handling for envCache in getKeys() #48099

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b48413
fix(config): Add missing handling for envCache in getKeys()
joshtrichards Jun 26, 2024
cf75265
fix(config): add envCache tests for getKeys()
joshtrichards Jun 26, 2024
c46fb54
fix: switch from explode to substr (faster)
joshtrichards Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: switch from explode to substr (faster) 
Signed-off-by: Josh Richards <[email protected]>
  • Loading branch information
@joshtrichards @backportbot
joshtrichards authored and backportbot[bot] committed Sep 16, 2024
commit c46fb548c253fec69b58b57fccc87f8195ab6bf7
3 changes: 2 additions & 1 deletion lib/private/Config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,9 +259,10 @@ private function readData() {
// grab any "NC_" environment variables
$envRaw = getenv();
// only save environment variables prefixed with "NC_" in the cache
$envPrefixLen = strlen(self::ENV_PREFIX);
foreach ($envRaw as $rawEnvKey => $rawEnvValue) {
if (str_starts_with($rawEnvKey, self::ENV_PREFIX)) {
$realKey = explode(self::ENV_PREFIX, $rawEnvKey)[1];
$realKey = substr($rawEnvKey, $envPrefixLen);
$this->envCache[$realKey] = $rawEnvValue;
}
}
Expand Down