[stable29] fix(files): Ensure children are removed from folder and not duplicated #48239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
force-pushed
the
backport/47905/stable29
branch
from
daedbb5 to
1a2775e
Compare
susnux
approved these changes
Oct 15, 2024
Contributor
|
/compile |
artonge
approved these changes
Oct 15, 2024
susnux
force-pushed
the
backport/47905/stable29
branch
from
75af0c0 to
2357f50
Compare
Contributor
|
/compile |
* Resolves #47904 We need to make sure that we only add one source (unique!) once as a child, this is ensured by simply use a native `Set`. Also we need to remove children on from folders when the `files:node:deleted` event is emitted. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
backport/47905/stable29
branch
from
c419383 to
a8e323e
Compare
Contributor
|
/compile amend/ |
nextcloud-command
force-pushed
the
backport/47905/stable29
branch
from
a8e323e to
90a6471
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
susnux
force-pushed
the
backport/47905/stable29
branch
from
90a6471 to
441e0f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #47905
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.