Skip to content

[stable30] fix(tests): Fix test selection and run unit tests of DAV and user_status #48286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 7 commits into from
Sep 25, 2024
Merged

[stable30] fix(tests): Fix test selection and run unit tests of DAV and user_status #48286

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8cf91a3
fix(tests): Fix test selection and run unit tests of DAV and user_status
nickvergessen Sep 19, 2024
4b570cf
fix(user_status): Fix integration test of user status
nickvergessen Sep 19, 2024
a75e432
test: fix ContactsMigratorTest
miaulalala Sep 19, 2024
04a5e49
fix(tests): Make timing test more reliable
nickvergessen Sep 24, 2024
cd27ba7
fix(tests): Also check that the backup status works
nickvergessen Sep 24, 2024
5bd1e28
fix(tests): Check that the revert was successful
nickvergessen Sep 24, 2024
abe8243
fix(querybuilder): Fix boolean type so that oracle handles boolean well
nickvergessen Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(tests): Make timing test more reliable 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed Sep 25, 2024
commit 04a5e492edc84d955c2a0a5e20445ee1bb56a2ea
5 changes: 4 additions & 1 deletion apps/user_status/tests/Integration/Service/StatusServiceIntegrationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,17 +42,20 @@ public function testNoStatusYet(): void {
}

public function testCustomStatusMessageTimestamp(): void {
$before = time();
$this->service->setCustomMessage(
'test123',
'🍕',
'Lunch',
null,
);
$after = time();

$status = $this->service->findByUserId('test123');

self::assertSame('Lunch', $status->getCustomMessage());
self::assertGreaterThanOrEqual(time(), $status->getStatusMessageTimestamp());
self::assertGreaterThanOrEqual($before, $status->getStatusMessageTimestamp());
self::assertLessThanOrEqual($after, $status->getStatusMessageTimestamp());
}

public function testOnlineStatusKeepsMessageTimestamp(): void {
Expand Down