Skip to content

More reliable user_status tests #48344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 3 commits into from
Sep 25, 2024
Merged

More reliable user_status tests #48344

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec6ed0c
fix(tests): Make timing test more reliable
nickvergessen Sep 24, 2024
134bfb8
fix(tests): Also check that the backup status works
nickvergessen Sep 24, 2024
79084d5
fix(tests): Check that the revert was successful
nickvergessen Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(tests): Also check that the backup status works 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed Sep 25, 2024
commit 134bfb8437c5e78026e29673a937ec3b9e322b6a
12 changes: 12 additions & 0 deletions apps/user_status/tests/Integration/Service/StatusServiceIntegrationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,15 +98,27 @@ public function testCreateRestoreBackupAutomatically(): void {
'meeting',
true,
);

self::assertSame(
'meeting',
$this->service->findByUserId('test123')->getMessageId(),
);
self::assertSame(
IUserStatus::ONLINE,
$this->service->findByUserId('_test123')->getStatus(),
);

$this->service->revertUserStatus(
'test123',
'meeting',
);

try {
$this->service->findByUserId('_test123');
$this->fail('Expected DoesNotExistException() to be thrown when finding backup status after reverting');
} catch (DoesNotExistException) {
}

self::assertSame(
IUserStatus::ONLINE,
$this->service->findByUserId('test123')->getStatus(),
Expand Down