Skip to content

[stable30] fix(icons): Document icon requirements for notifications and activities #48358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Sep 25, 2024
Merged

[stable30] fix(icons): Document icon requirements for notifications and activities #48358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/public/Activity/IEvent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,10 @@ public function getObjectName(): string;
public function getLink(): string;

/**
* Set the absolute url for the icon (should be colored black or not have a color)
*
* It's automatically color inverted by clients when needed
*
* @param string $icon
* @return $this
* @throws InvalidValueException if the icon is invalid
Expand All @@ -319,6 +323,10 @@ public function getLink(): string;
public function setIcon(string $icon): self;

/**
* Get the absolute url for the icon (should be colored black or not have a color)
*
* It's automatically color inverted by clients when needed
*
* @return string
* @since 11.0.0
*/
Expand Down
8 changes: 8 additions & 0 deletions lib/public/Notification/INotification.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,10 @@ public function setLink(string $link): INotification;
public function getLink(): string;

/**
* Set the absolute url for the icon (should be colored black or not have a color)
*
* It's automatically color inverted by clients when needed
*
* @param string $icon
* @return $this
* @throws InvalidValueException if the icon is invalid
Expand All @@ -258,6 +262,10 @@ public function getLink(): string;
public function setIcon(string $icon): INotification;

/**
* Get the absolute url for the icon (should be colored black or not have a color)
*
* It's automatically color inverted by clients when needed
*
* @return string
* @since 11.0.0
*/
Expand Down