fix(files_sharing): Parse OCM share permissions from OCM and not OCS prop #48366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…prop Signed-off-by: provokateurin <[email protected]>
Member
Author
|
/backport to stable30 |
Member
Author
|
/backport to stable29 |
Member
Author
|
/backport to stable28 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
come-nc
reviewed
Sep 26, 2024
come-nc
reviewed
Sep 26, 2024
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
Ok for the logic, but error handling is missing, $reponse could be false, or could be missing the keys.
Signed-off-by: provokateurin <[email protected]>
…ing share permission props Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
fix/files_sharing/ocm-permissions
branch
from
9266e84 to
13d1cb7
Compare
come-nc
approved these changes
Sep 26, 2024
kesselb
approved these changes
Sep 26, 2024
This was referenced Sep 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checks for OCM permissions prop, but parses them from the OCS permissions prop.
Checklist