Skip to content

Auto import Nextcloud classes in rector runs #48371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
come-nc merged 4 commits into from
Oct 15, 2024
Merged

Auto import Nextcloud classes in rector runs #48371

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2815344
chore(rector): Add rule to import Nextcloud classes in all files
come-nc Sep 26, 2024
4ff9b3e
feat(rector): Skip classes with a name too common from auto use state…
come-nc Oct 10, 2024
1580c86
chore(apps): Apply new rector configuration to autouse classes
come-nc Oct 10, 2024
be80943
chore: Update baseline after rector refactoring
come-nc Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(rector): Skip classes with a name too common from auto use state… 
…ment

Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc
come-nc committed Oct 15, 2024
commit 4ff9b3e0ce53227e2be47c4c2dcb1fdc3e540b5f
14 changes: 14 additions & 0 deletions build/rector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,21 @@ class NextcloudNamespaceSkipVoter implements ClassNameImportSkipVoterInterface {
'OCA',
'OCP',
];
private array $skippedClassNames = [
'Backend',
'Connection',
'Exception',
'IManager',
'IProvider',
'Manager',
'Plugin',
'Provider',
];
public function shouldSkip(File $file, FullyQualifiedObjectType $fullyQualifiedObjectType, Node $node) : bool {
if (in_array($fullyQualifiedObjectType->getShortName(), $this->skippedClassNames)) {
// Skip common class names to avoid confusion
return true;
}
foreach ($this->namespacePrefixes as $prefix) {
if (str_starts_with($fullyQualifiedObjectType->getClassName(), $prefix . '\\')) {
// Import Nextcloud namespaces
Expand Down