fix(dav): Emit BeforeZipCreatedEvent when creating folder zip archive
#48438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| $folder = $node->getNode(); | ||
| $event = new BeforeZipCreatedEvent($folder, $files); |
Check notice
Code scanning / Psalm
ArgumentTypeCoercion
susnux
force-pushed
the
fix/bring-back-zip-event
branch
from
6a7890e to
05505f9
Compare
| // allow setup of additional auth backends | ||
| $event = new SabrePluginEvent($this->server); | ||
| $dispatcher->dispatch('OCA\DAV\Connector\Sabre::authInit', $event); | ||
| $eventDispatcher->dispatch('OCA\DAV\Connector\Sabre::authInit', $event); |
Check notice
Code scanning / Psalm
DeprecatedMethod
|
|
||
| // allow setup of additional plugins | ||
| $dispatcher->dispatch('OCA\DAV\Connector\Sabre::addPlugin', $event); | ||
| $eventDispatcher->dispatch('OCA\DAV\Connector\Sabre::addPlugin', $event); |
Check notice
Code scanning / Psalm
DeprecatedMethod
provokateurin
approved these changes
Sep 29, 2024
This is required to not break behavior on zip download (apps should be able to react to zip download especially for shares). Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/bring-back-zip-event
branch
from
05505f9 to
e0c00af
Compare
come-nc
approved these changes
Oct 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have overseen this while implementing the zip folder DAV plugin.
This is required to not break behavior on zip download (apps should be able to react to zip download especially for shares).
(the event in server is pretty useless but apps might rely on it, also there is room for cleanup of all of that logic where I did now some preparation while touching it, will do in a followup the full cleanup soon).
Checklist