Skip to content

Conversation

@kesselb
Copy link
Contributor

@kesselb kesselb commented Sep 30, 2024

Summary

Psalm now fails when a baseline update is needed.

TODO

  • CI
  • No warning about invalid sarif file

Checklist

@kesselb kesselb self-assigned this Sep 30, 2024
@kesselb kesselb added the 2. developing Work in progress label Sep 30, 2024
@kesselb kesselb force-pushed the ci/noid/require-up-to-date-psalm-paseline branch from e9c0c2f to 077ed74 Compare September 30, 2024 16:05
@kesselb kesselb changed the title ci: dont update psalm baseline ci: fail psalm when baseline update required Sep 30, 2024
@kesselb kesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 30, 2024
@kesselb kesselb added this to the Nextcloud 31 milestone Sep 30, 2024
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal but better than nothing 👍

@kesselb kesselb merged commit 1fff4e1 into master Sep 30, 2024
@kesselb kesselb deleted the ci/noid/require-up-to-date-psalm-paseline branch September 30, 2024 17:00
@kesselb
Copy link
Contributor Author

kesselb commented Sep 30, 2024

/backport to stable30

@kesselb
Copy link
Contributor Author

kesselb commented Sep 30, 2024

/backport to stable29

@kesselb
Copy link
Contributor Author

kesselb commented Sep 30, 2024

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants