Skip to content

[stable28] ci: fail psalm when baseline update required #48470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kesselb merged 3 commits into from
Oct 30, 2024
+1,552 −1,128
Merged

[stable28] ci: fail psalm when baseline update required #48470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccc5154
ci: fail psalm when baseline update required
kesselb Sep 30, 2024
641fa95
chore: update psalm
kesselb Oct 30, 2024
ead6b70
chore: update psalm baseline
kesselb Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/static-code-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:

- name: Show potential changes in Psalm baseline
if: always()
run: git diff -- . ':!lib/composer'
run: git diff --exit-code -- . ':!lib/composer'

- name: Upload Analysis results to GitHub
if: always()
Expand Down Expand Up @@ -98,4 +98,4 @@ jobs:

- name: Show potential changes in Psalm baseline
if: always()
run: git diff -- . ':!lib/composer'
run: git diff --exit-code -- . ':!lib/composer'
100 changes: 51 additions & 49 deletions build/psalm-baseline-ocp.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<files psalm-version="5.9.0@8b9ad1eb9e8b7d3101f949291da2b9f7767cd163">
<files psalm-version="5.26.1@d747f6500b38ac4f7dfc5edbcae6e4b637d7add0">
<file src="lib/private/legacy/OC_Template.php">
<UndefinedClass>
<code>OC</code>
<code><![CDATA[OC]]></code>
</UndefinedClass>
</file>
<file src="lib/public/AppFramework/ApiController.php">
Expand All @@ -15,149 +15,151 @@
<code><![CDATA[new RouteConfig($this->container, $router, $routes)]]></code>
</InternalMethod>
<UndefinedClass>
<code>\OC</code>
<code><![CDATA[\OC]]></code>
</UndefinedClass>
</file>
<file src="lib/public/AppFramework/Db/Entity.php">
<InvalidNullableReturnType>
<code>string</code>
<code><![CDATA[string]]></code>
</InvalidNullableReturnType>
<NullableReturnStatement>
<code>$column</code>
<code><![CDATA[$column]]></code>
</NullableReturnStatement>
</file>
<file src="lib/public/AppFramework/Http/RedirectToDefaultAppResponse.php">
<UndefinedClass>
<code>\OC</code>
<code><![CDATA[\OC]]></code>
</UndefinedClass>
</file>
<file src="lib/public/AppFramework/Http/Response.php">
<UndefinedClass>
<code>\OC</code>
<code>\OC</code>
<code><![CDATA[\OC]]></code>
</UndefinedClass>
</file>
<file src="lib/public/Cache/CappedMemoryCache.php">
<MissingTemplateParam>
<code>\ArrayAccess</code>
<code><![CDATA[\ArrayAccess]]></code>
</MissingTemplateParam>
</file>
<file src="lib/public/DB/QueryBuilder/IQueryBuilder.php">
<InvalidDocblock>
<code><![CDATA[public function createFunction($call);]]></code>
</InvalidDocblock>
</file>
<file src="lib/public/Defaults.php">
<UndefinedClass>
<code>\OC</code>
<code><![CDATA[\OC]]></code>
</UndefinedClass>
</file>
<file src="lib/public/Diagnostics/IQueryLogger.php">
<LessSpecificImplementedReturnType>
<code>mixed</code>
<code><![CDATA[mixed]]></code>
</LessSpecificImplementedReturnType>
</file>
<file src="lib/public/EventDispatcher/GenericEvent.php">
<MissingTemplateParam>
<code>ArrayAccess</code>
<code>IteratorAggregate</code>
<code><![CDATA[ArrayAccess]]></code>
<code><![CDATA[IteratorAggregate]]></code>
</MissingTemplateParam>
</file>
<file src="lib/public/Federation/Exceptions/ActionNotSupportedException.php">
<UndefinedClass>
<code>\OC</code>
<code><![CDATA[\OC]]></code>
</UndefinedClass>
</file>
<file src="lib/public/Federation/Exceptions/AuthenticationFailedException.php">
<UndefinedClass>
<code>\OC</code>
<code><![CDATA[\OC]]></code>
</UndefinedClass>
</file>
<file src="lib/public/Federation/Exceptions/BadRequestException.php">
<UndefinedClass>
<code>\OC</code>
<code><![CDATA[\OC]]></code>
</UndefinedClass>
</file>
<file src="lib/public/Federation/Exceptions/ProviderAlreadyExistsException.php">
<UndefinedClass>
<code>\OC</code>
<code><![CDATA[\OC]]></code>
</UndefinedClass>
</file>
<file src="lib/public/Federation/Exceptions/ProviderDoesNotExistsException.php">
<UndefinedClass>
<code>\OC</code>
<code><![CDATA[\OC]]></code>
</UndefinedClass>
</file>
<file src="lib/public/Files.php">
<FalsableReturnStatement>
<code>\OC_App::getStorage($app)</code>
<code><![CDATA[\OC_App::getStorage($app)]]></code>
</FalsableReturnStatement>
<UndefinedClass>
<code>\OC</code>
<code><![CDATA[\OC]]></code>
</UndefinedClass>
</file>
<file src="lib/public/Files/Cache/ICacheEntry.php">
<MissingTemplateParam>
<code>ArrayAccess</code>
<code><![CDATA[ArrayAccess]]></code>
</MissingTemplateParam>
</file>
<file src="lib/public/Files/LockNotAcquiredException.php">
<UndefinedClass>
<code>\OC</code>
<code><![CDATA[\OC]]></code>
</UndefinedClass>
</file>
<file src="lib/public/Files/StorageAuthException.php">
<UndefinedClass>
<code>\OC</code>
<code><![CDATA[\OC]]></code>
</UndefinedClass>
</file>
<file src="lib/public/Files/StorageBadConfigException.php">
<UndefinedClass>
<code>\OC</code>
<code><![CDATA[\OC]]></code>
</UndefinedClass>
</file>
<file src="lib/public/Files/StorageConnectionException.php">
<UndefinedClass>
<code>\OC</code>
<code><![CDATA[\OC]]></code>
</UndefinedClass>
</file>
<file src="lib/public/Files/StorageNotAvailableException.php">
<UndefinedClass>
<code>\OC</code>
<code><![CDATA[\OC]]></code>
</UndefinedClass>
</file>
<file src="lib/public/Files/StorageTimeoutException.php">
<UndefinedClass>
<code>\OC</code>
<code><![CDATA[\OC]]></code>
</UndefinedClass>
</file>
<file src="lib/public/L10N/ILanguageIterator.php">
<MissingTemplateParam>
<code>\Iterator</code>
<code><![CDATA[\Iterator]]></code>
</MissingTemplateParam>
</file>
<file src="lib/public/Template.php">
<UndefinedFunction>
<code>\html_select_options($options, $selected, $params)</code>
<code>\human_file_size($bytes)</code>
<code>\image_path($app, $image)</code>
<code>\mimetype_icon($mimetype)</code>
<code>\preview_icon($path)</code>
<code>\publicPreview_icon($path, $token)</code>
<code>\relative_modified_date($timestamp, null, $dateOnly)</code>
<code><![CDATA[\html_select_options($options, $selected, $params)]]></code>
<code><![CDATA[\human_file_size($bytes)]]></code>
<code><![CDATA[\image_path($app, $image)]]></code>
<code><![CDATA[\mimetype_icon($mimetype)]]></code>
<code><![CDATA[\preview_icon($path)]]></code>
<code><![CDATA[\publicPreview_icon($path, $token)]]></code>
<code><![CDATA[\relative_modified_date($timestamp, null, $dateOnly)]]></code>
</UndefinedFunction>
</file>
<file src="lib/public/Util.php">
<UndefinedClass>
<code>\OC</code>
<code>\OC</code>
<code>\OC</code>
<code>\OC</code>
<code>\OC</code>
<code>\OC</code>
<code>\OC</code>
<code>\OC</code>
<code>\OC</code>
<code>\OC</code>
<code>\OC</code>
<code>\OC</code>
<code>\OC</code>
<code>\OC</code>
<code><![CDATA[\OC]]></code>
<code><![CDATA[\OC]]></code>
<code><![CDATA[\OC]]></code>
<code><![CDATA[\OC]]></code>
<code><![CDATA[\OC]]></code>
<code><![CDATA[\OC]]></code>
<code><![CDATA[\OC]]></code>
<code><![CDATA[\OC]]></code>
<code><![CDATA[\OC]]></code>
<code><![CDATA[\OC]]></code>
<code><![CDATA[\OC]]></code>
<code><![CDATA[\OC]]></code>
</UndefinedClass>
</file>
</files>
Loading
Loading