Skip to content

Conversation

@provokateurin
Copy link
Member

@provokateurin provokateurin commented Oct 2, 2024

Summary

#48361 added error logs when the output column is too long. #48521 shows the output columns weren't extracted correctly as it contained display_mode as display_mode_default which is actually fine because display_mode_default is only 20 chars.

Checklist

@provokateurin provokateurin added bug 3. to review Waiting for reviews labels Oct 2, 2024
@provokateurin provokateurin added this to the Nextcloud 31 milestone Oct 2, 2024
@provokateurin provokateurin requested review from a team, Altahrim, come-nc, nickvergessen and yemkareems and removed request for a team October 2, 2024 09:57
@provokateurin
Copy link
Member Author

/backport to stable30

@provokateurin provokateurin mentioned this pull request Oct 2, 2024
4 tasks
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane, did not test.

Copy link
Member

@icewind1991 icewind1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we should discourage apps from doing aliases like this instead of using selectAlias

@provokateurin provokateurin merged commit 8638a89 into master Oct 3, 2024
@provokateurin provokateurin deleted the fix/querybuilder/output-columns-aliases branch October 3, 2024 13:48
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QueryBuilder output columns incorrect

5 participants