Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Oct 2, 2024

Summary

Prod Packages Operation Base Target
psr/log Upgraded 2.0.0 3.0.2
stecman/symfony-console-completion Upgraded 0.11.0 v0.13.0
symfony/console Upgraded v5.4.35 v6.4.12
symfony/event-dispatcher Upgraded v5.4.26 v6.4.8
symfony/event-dispatcher-contracts Upgraded v3.0.2 v3.5.0
symfony/http-foundation Upgraded v5.4.25 v6.4.12
symfony/mailer Upgraded v5.4.22 v6.4.12
symfony/mime Upgraded v5.4.19 v6.4.12
symfony/polyfill-intl-idn Upgraded v1.29.0 v1.31.0
symfony/polyfill-php83 New - v1.31.0
symfony/process Upgraded v5.4.34 v6.4.12
symfony/routing Upgraded v5.4.25 v6.4.12
symfony/service-contracts Upgraded v3.0.2 v3.5.0
symfony/polyfill-php72 Removed v1.29.0 -
symfony/polyfill-php73 Removed v1.28.0 -

Checklist

@nickvergessen nickvergessen added 3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update dependencies labels Oct 2, 2024
@nickvergessen nickvergessen added this to the Nextcloud 31 milestone Oct 2, 2024
@nickvergessen nickvergessen self-assigned this Oct 2, 2024
@nickvergessen nickvergessen force-pushed the dependabot/composer/symfony-6.4 branch 2 times, most recently from 9b38338 to 4e53ecc Compare October 4, 2024 14:26
@nickvergessen nickvergessen requested a review from come-nc October 7, 2024 09:37
@nickvergessen nickvergessen force-pushed the dependabot/composer/symfony-6.4 branch from 4e53ecc to 998d972 Compare October 7, 2024 10:03
@nickvergessen nickvergessen force-pushed the dependabot/composer/symfony-6.4 branch from 998d972 to 315e465 Compare October 7, 2024 10:12
@come-nc
Copy link
Contributor

come-nc commented Oct 7, 2024

Can we document based on the arguments? I don't think so

@nickvergessen To be precise, I think we can with https://psalm.dev/docs/annotating_code/type_syntax/conditional_types/ , but it’s a bit complicated.

Maybe we should simply add in Base:

function getQuestionHelper(): QuestionHelper {
/** @var QuestionHelper */
return $this->getHelper('question');
}

Seeing how often this is used.

@nickvergessen
Copy link
Member Author

Maybe we should simply add in Base:

I'm up for that, if we add a public interface. I don't feel like typing 3rdparty with implied assumptions

@nickvergessen nickvergessen merged commit c3dfb9a into master Oct 7, 2024
@nickvergessen nickvergessen deleted the dependabot/composer/symfony-6.4 branch October 7, 2024 11:08
kesselb added a commit to kesselb/nextcloud-ocp that referenced this pull request Oct 8, 2024
@nickvergessen
Copy link
Member Author

/backport e6cd105 to stable29

@nickvergessen
Copy link
Member Author

/backport e6cd105 to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews dependencies pending documentation This pull request needs an associated documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants