Skip to content

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Oct 2, 2024

Summary

Fix #48407

Before After
image image

Checklist

@Pytal Pytal added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: theming labels Oct 2, 2024
@Pytal Pytal added this to the Nextcloud 31 milestone Oct 2, 2024
@Pytal Pytal requested review from a team and nfebe October 2, 2024 23:23
@Pytal Pytal self-assigned this Oct 2, 2024
@Pytal Pytal requested review from artonge and susnux and removed request for a team October 2, 2024 23:23
@Pytal
Copy link
Member Author

Pytal commented Oct 2, 2024

/compile

@Pytal
Copy link
Member Author

Pytal commented Oct 2, 2024

/backport to stable30

Signed-off-by: nextcloud-command <[email protected]>
@ShGKme
Copy link
Contributor

ShGKme commented Oct 3, 2024

If I'm not mistaken, @marcoambrosini had some plans here, was discussed when NcSettingsSection become force limited

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better :)
Yet I think limiting the width is an mistake here, like with the profile settings it should take more horizontal space as 1920px is basically the norm today.

@Pytal Pytal merged commit 9095b49 into master Oct 3, 2024
@Pytal Pytal deleted the fix/themes-layout branch October 3, 2024 12:28
@marcoambrosini
Copy link
Member

Nice improvement!

@marcoambrosini
Copy link
Member

Yet I think limiting the width is an mistake here, like with the profile settings it should take more horizontal space as 1920px is basically the norm today.

Since there can be long paragraphs in the settings, I'd like to limit the width to improve readability

@Pytal
Copy link
Member Author

Pytal commented Oct 3, 2024

Yet I think limiting the width is an mistake here, like with the profile settings it should take more horizontal space as 1920px is basically the norm today.

Since there can be long paragraphs in the settings, I'd like to limit the width to improve readability

The width is force-limited to 900px already on 30+ but do you think we should limit it more @marcoambrosini?

@marcoambrosini
Copy link
Member

I think that's ok @Pytal !

@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: theming

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Theme previews / selector looks to crowded

7 participants