feat(setupchecks): add row format setup check for MySQL databases #48547
Conversation
Altahrim
requested review from
provokateurin,
sorbaugh and
yemkareems
and removed request for
a team
|
|
||
| public function run(): SetupResult { | ||
| if (!$this->connection->getDatabasePlatform() instanceof MySQLPlatform) { | ||
| return SetupResult::success($this->l10n->t('You are not using MySQL')); |
There was a problem hiding this comment.
Do you think it makes sense to introduce something like SetupResult::skipped and then filter out the setup checks with severity = skipped by default? If you think so, I would log a feature request.
| $sql = 'SELECT table_name | ||
| FROM information_schema.tables | ||
| WHERE table_schema = ? | ||
| AND table_name LIKE "*PREFIX*%" | ||
| AND row_format = "Compressed";'; |
There was a problem hiding this comment.
can you not run this with our query builder?
There was a problem hiding this comment.
Good question!
I didn't find it useful because it's only for MySQL like DBs and I am not sure I can query another database 🤔
Altahrim
added
2. developing
Signed-off-by: Benjamin Gaussorgues <[email protected]>
Altahrim
force-pushed
the
feat/row_format_check
branch
from
1ea8e6a to
f70f70e
Compare
Altahrim
added
3. to review
|
|
||
| return SetupResult::warning( | ||
| $this->l10n->n( | ||
| 'Table %s is not using ROW_FORMAT=Dynamic. This format offers the best database performances for Nextcloud. Please change the row format to Dynamic.', |
There was a problem hiding this comment.
plurals without %n are confusing for translators.
I would say the last line of https://docs.nextcloud.com/server/latest/developer_manual/basics/front-end/l10n.html#correct-plurals is applicable here
|
How about not only throwing a warning and point to the DB documentation, but give advice on how to fix the warning? Mysql docs do explain the differences of the formats, but it's more handy to give explicit examples (or do the conversion automatically) |
|
@Miyamoto72 The conversion can be very long so I think it's better if administrators can run the migration at chosen time. However, if you have a better formulation in mind, feel free to open a pull request with it. All improvements are welcome :) |
|
I reckon there's many a user running his/her own NC installation on a home server without being an IT expert (even though this would be better, I admit., including me. |
|
+1 for an automated repair step. There seems to be a large number of users presented with this message after upgrading to 31.0 (see this forum thread). I think the average user should not have to know SQL or copy a script off of the forum to fix this. |
Summary
Add a setup check to warn about tables using ROW_FORMAT=Compressed
MySQL specific
Checklist