feat(encryption): Migrate from hooks to events #48560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
force-pushed
the
fix/migrate-encryption-away-from-hooks
branch
2 times, most recently
from
7b456c7 to
fc22188
Compare
Contributor
Author
|
Getting there, only one more failure. For some reason it’s not the same one locally and in the CI 🤷 |
come-nc
force-pushed
the
fix/migrate-encryption-away-from-hooks
branch
from
1d2e3f4 to
f392a55
Compare
Merged
come-nc
force-pushed
the
fix/migrate-encryption-away-from-hooks
branch
from
efb5812 to
4a3def9
Compare
Merged
come-nc
force-pushed
the
fix/migrate-encryption-away-from-hooks
branch
from
314010a to
14b8770
Compare
Merged
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
come-nc
force-pushed
the
fix/migrate-encryption-away-from-hooks
branch
from
d47a006 to
bfbc787
Compare
come-nc
added
2. developing
come-nc
force-pushed
the
fix/migrate-encryption-away-from-hooks
branch
from
bfbc787 to
f299305
Compare
Merged
icewind1991
reviewed
Jan 21, 2025
Merged
come-nc
force-pushed
the
fix/migrate-encryption-away-from-hooks
branch
from
f299305 to
d5fcd9b
Compare
come-nc
force-pushed
the
fix/migrate-encryption-away-from-hooks
branch
from
840489b to
f059ba8
Compare
come-nc
requested review from
ArtificialOwl and
icewind1991
and removed request for
a team
…ffects It was clearing the hooks with the same results before Signed-off-by: Côme Chilliet <[email protected]>
…ects Adapt tests a bit to make them pass with Encryption wrapper registered Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
…ith encryption registered Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
…ems in files_versions tests Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
…tions Signed-off-by: Côme Chilliet <[email protected]>
…n wrapper is present Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
to avoid back&forth between path and Node object Signed-off-by: Côme Chilliet <[email protected]>
…store in moveFromStorage Signed-off-by: Côme Chilliet <[email protected]>
…rs are created with private key Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
fix/migrate-encryption-away-from-hooks
branch
from
a7e8847 to
43418ee
Compare
come-nc
added
3. to review
icewind1991
approved these changes
May 14, 2025
susnux
approved these changes
May 14, 2025
artonge
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #32128
Summary
This is not half as clean as I would’ve liked, because original code is convoluted.
The owner thing in the event listener is ugly and probably incorrect but it was there before in HookManager class.
Checklist