Skip to content

Conversation

@provokateurin
Copy link
Member

Summary

#47896 broke groupfolders tests with this error:

4) OCA\GroupFolders\Tests\Trash\TrashBackendTest::testHideDeletedTrashItemInDeletedParentFolderAcl
Error: Typed property OC\User\User::$backend must not be accessed before initialization

/home/jld3103/src/github.com/nextcloud/server/lib/private/User/User.php:104
/home/jld3103/src/github.com/nextcloud/server/apps/groupfolders/lib/ACL/UserMapping/UserMappingManager.php:27
/home/jld3103/src/github.com/nextcloud/server/apps/groupfolders/lib/ACL/RuleManager.php:112
/home/jld3103/src/github.com/nextcloud/server/apps/groupfolders/lib/ACL/ACLManager.php:227
/home/jld3103/src/github.com/nextcloud/server/apps/groupfolders/lib/Trash/TrashBackend.php:333
/home/jld3103/src/github.com/nextcloud/server/apps/groupfolders/lib/Trash/TrashBackend.php:56
/home/jld3103/src/github.com/nextcloud/server/apps/groupfolders/tests/Trash/TrashBackendTest.php:203

It uses the createUser() method of the UserTrait which wasn't properly initializing the parent by calling the parent constructor.

Checklist

@provokateurin provokateurin added bug 3. to review Waiting for reviews labels Oct 8, 2024
@provokateurin provokateurin added this to the Nextcloud 31 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants