Skip to content

[stable30] fix(settings): Use axios directly for health check to preven URL sanitizing #48615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 2 commits into from
Oct 8, 2024
Merged

[stable30] fix(settings): Use axios directly for health check to preven URL sanitizing #48615

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1f2658
fix(settings): Use axios directly for health check to preven URL sani…
susnux Jun 10, 2024
a817681
chore(assets): Recompile assets
nextcloud-command Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(settings): Use axios directly for health check to preven URL sani… 
…tizing

When using Apache with `DirectorySlash` it will respond with 301 and the URL with trailing slash.
But when using traefik as the reverse proxy it can not rewrite redirects, this leads to the problem
that the Apache response is using HTTP in the redirect but the real server (traefik) is only listening on HTTPS.

Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux @backportbot
susnux authored and backportbot[bot] committed Oct 8, 2024
commit f1f265894ef577c729b2b368dc61eb0342beee19
3 changes: 2 additions & 1 deletion apps/settings/src/store/apps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

import api from './api.js'
import Vue from 'vue'
import axios from '@nextcloud/axios'
import { generateUrl } from '@nextcloud/router'
import { showError, showInfo } from '@nextcloud/dialogs'
import { loadState } from '@nextcloud/initial-state'
Expand Down Expand Up @@ -178,7 +179,7 @@ const actions = {
})

// check for server health
return api.get(generateUrl('apps/files/'))
return axios.get(generateUrl('apps/files/'))
.then(() => {
if (response.data.update_required) {
showInfo(
Expand Down