Skip to content

chore(db): Apply query prepared statements #48724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Oct 17, 2024
Merged

chore(db): Apply query prepared statements #48724

nickvergessen merged 1 commit into from
Oct 17, 2024

Conversation

@solracsf
Copy link
Member

@solracsf solracsf commented Oct 16, 2024 •
edited
Loading

Summary

Apply correct execute type on each query.

This is th 1st batch PR, others will follow, to not have one single PR with a gazillion changes to be reviewed.

TODO

  • CI

Checklist

@solracsf solracsf added the 2. developing Work in progress label Oct 16, 2024
@solracsf solracsf force-pushed the dbQueriesExecStmt branch 4 times, most recently from 1511e8b to 70db9dc Compare October 16, 2024 16:31
@solracsf solracsf added 3. to review Waiting for reviews feature: database Database related DB and removed 2. developing Work in progress labels Oct 17, 2024
@solracsf solracsf marked this pull request as ready for review October 17, 2024 07:20
@solracsf
chore(db): Correctly apply query types
c254855 
fix: psalm

fix: error

fix: add batch

fix: fatal error

fix: add batch

chore: add batch

chore: add batch

fix: psalm

fix: typo

fix: psalm

fix: return bool

fix: revert Manager
@solracsf solracsf changed the title [WiP🔨] : chore(db): Correctly apply query types chore(db): Correctly apply query types Oct 17, 2024
@solracsf solracsf changed the title chore(db): Correctly apply query types chore(db): Apply query prepared statements Oct 17, 2024
@solracsf solracsf added this to the Nextcloud 31 milestone Oct 17, 2024
@nickvergessen nickvergessen merged commit 40fd76f into master Oct 17, 2024
@nickvergessen nickvergessen deleted the dbQueriesExecStmt branch October 17, 2024 09:29
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@miaulalala miaulalala Awaiting requested review from miaulalala

@st3iny st3iny Awaiting requested review from st3iny

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski SebastianKrupinski is a code owner

@kesselb kesselb Awaiting requested review from kesselb kesselb is a code owner

Assignees

No one assigned

Labels

3. to review Waiting for reviews feature: database Database related DB

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

4 participants

@solracsf @nickvergessen @ChristophWurst