Skip to content

fix: log which file cannot be opened #48793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Dec 4, 2024
Merged

fix: log which file cannot be opened #48793

skjnldsv merged 1 commit into from
Dec 4, 2024

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Oct 18, 2024 •
edited
Loading

And log whether the fs tells us the file exists

This should debugging issues easier

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Oct 18, 2024
@icewind1991 icewind1991 added this to the Nextcloud 31 milestone Oct 18, 2024
@icewind1991 icewind1991 requested review from a team, ArtificialOwl, artonge and come-nc and removed request for a team October 18, 2024 14:51
come-nc
come-nc reviewed Nov 4, 2024
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@icewind1991 Is $path never leaking server path?

@icewind1991
Copy link
Member Author

icewind1991 commented Nov 4, 2024

@icewind1991 Is $path never leaking server path?

$path is the path of the requested file, so nothing the user doesn't already know

@skjnldsv skjnldsv enabled auto-merge November 9, 2024 13:36
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 9, 2024
@skjnldsv skjnldsv merged commit 6669c49 into master Dec 4, 2024
188 checks passed
@skjnldsv skjnldsv deleted the dav-open-log-path branch December 4, 2024 19:18
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
@kesselb
Copy link
Contributor

kesselb commented Mar 19, 2025

/backport to stable30

@backportbot backportbot bot mentioned this pull request Mar 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@come-nc come-nc come-nc approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

6 participants

@icewind1991 @kesselb @artonge @skjnldsv @come-nc