Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Oct 18, 2024

Backport of #48696

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from Ivansss, Pytal and susnux October 18, 2024 16:56
@backportbot backportbot bot added this to the Nextcloud 28.0.12 milestone Oct 18, 2024
Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

1. Use proper translated strings
2. Fix invalid use of translation message on API result
3. Log all errors

Co-authored-by: Ferdinand Thiessen <[email protected]>
Co-authored-by: Pytal <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the backport/48696/stable28 branch from 94ad771 to cb96578 Compare October 23, 2024 11:45
@susnux susnux marked this pull request as ready for review October 23, 2024 11:45
@susnux
Copy link
Contributor

susnux commented Oct 23, 2024

/compile

Signed-off-by: nextcloud-command <[email protected]>
@susnux susnux enabled auto-merge October 23, 2024 12:53
@susnux susnux merged commit 0977b7d into stable28 Oct 23, 2024
@susnux susnux deleted the backport/48696/stable28 branch October 23, 2024 13:24
@Altahrim Altahrim mentioned this pull request Oct 30, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants