[stable29] fix(files): Ensure renaming state is correctly reset #48797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
approved these changes
Oct 21, 2024
susnux
force-pushed
the
backport/48425/stable29
branch
from
ab0f13d to
0d1c5e3
Compare
susnux
approved these changes
Oct 28, 2024
susnux
force-pushed
the
backport/48425/stable29
branch
from
0d1c5e3 to
0eb5717
Compare
Contributor
|
/compile |
susnux
force-pushed
the
backport/48425/stable29
branch
from
208f497 to
a82e41f
Compare
nextcloud-command
force-pushed
the
backport/48425/stable29
branch
from
a82e41f to
73ed6ef
Compare
susnux
force-pushed
the
backport/48425/stable29
branch
2 times, most recently
from
b8ca901 to
caf0d4b
Compare
nextcloud-command
force-pushed
the
backport/48425/stable29
branch
2 times, most recently
from
a39d401 to
483f0d6
Compare
susnux
force-pushed
the
backport/48425/stable29
branch
2 times, most recently
from
0bd8fcf to
58fb9eb
Compare
Collaborator
|
/compile amend / |
nextcloud-command
force-pushed
the
backport/48425/stable29
branch
from
58fb9eb to
4e6d314
Compare
Problem: Is a node is renamed and the new name is out of the current visible list of nodes the component will be recycled, this means the props will change, so when the `onRename` functions is about to reset the state the `this.source` will point to a different node. To fix this, but also to separate business logic from visual representation, the logic is moved into the renaming store and the component is only responsible for rendering. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
backport/48425/stable29
branch
from
4e6d314 to
8588e49
Compare
TODO: Drop when we support Node 22. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
backport/48425/stable29
branch
from
8588e49 to
ca83966
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #48425
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.