Skip to content

[stable29] build: Print RTL limited characters in translation-checker #48857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 2 commits into from
Oct 23, 2024
Merged

[stable29] build: Print RTL limited characters in translation-checker #48857

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21eb62c
build: Print RTL limited characters in translation-checker
provokateurin Oct 22, 2024
ff2f346
build: Show the actual string
nickvergessen Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
build: Print RTL limited characters in translation-checker 
Signed-off-by: provokateurin <[email protected]>
  • Loading branch information
@provokateurin @backportbot
provokateurin authored and backportbot[bot] committed Oct 23, 2024
commit 21eb62c1556cabf7bebcb25defc9f2da8a8e5094
4 changes: 2 additions & 2 deletions build/translation-checker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@
$content = file_get_contents($file->getPathname());

$language = pathinfo($file->getFilename(), PATHINFO_FILENAME);
if (!in_array($language, $rtlLanguages, true) && preg_match('/[' . implode('', $rtlCharacters) . ']/u', $content)) {
$errors[] = $file->getPathname() . "\n" . ' ' . 'Contains a RTL limited character in the translations.' . "\n";
if (!in_array($language, $rtlLanguages, true) && preg_match('/[' . implode('', $rtlCharacters) . ']/u', $content, $matches)) {
$errors[] = $file->getPathname() . "\n" . ' ' . 'Contains a RTL limited characters in the translations. Offending Unicode codepoints: ' . implode(', ', array_map(static fn (string $match) => mb_ord($match), $matches)) . "\n";
}

$json = json_decode($content, true);
Expand Down