Skip to content

Conversation

@skjnldsv
Copy link
Member

We fallback to ?guestFallback=true only for the normal AvatarController
If we already know this is a guest user, we do not need to fallback at all, we can go straight to the GuestAvatarController

Before After
2024-10-25_12-06 2024-10-25_12-05

@skjnldsv skjnldsv requested review from a team and susnux October 25, 2024 10:07
@skjnldsv skjnldsv self-assigned this Oct 25, 2024
@skjnldsv skjnldsv requested review from sorbaugh and szaimen and removed request for a team October 25, 2024 10:07
@skjnldsv skjnldsv force-pushed the fix/federated-users branch from 1f9ca94 to a1ffa84 Compare October 25, 2024 10:18
@skjnldsv
Copy link
Member Author

Added tests

@skjnldsv

This comment was marked as resolved.

@skjnldsv skjnldsv requested a review from nfebe October 25, 2024 10:20
@skjnldsv

This comment was marked as resolved.

@skjnldsv

This comment was marked as resolved.

Signed-off-by: nextcloud-command <[email protected]>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 29, 2024
@skjnldsv skjnldsv merged commit bd4c5e1 into master Oct 29, 2024
@skjnldsv skjnldsv deleted the fix/federated-users branch October 29, 2024 06:31
@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 29, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. feature: files feature: sharing regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants