Skip to content

fix: encrypt and store password, decrypt and retrieve the same #48915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
provokateurin merged 5 commits into from
Oct 28, 2024
Merged

fix: encrypt and store password, decrypt and retrieve the same #48915

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
505dfd6
fix: encrypt and store password, decrypt and retrieve the same
yemkareems Oct 28, 2024
a74ef82
fix: crypto type made not nullable and tests run using ICrypto
yemkareems Oct 28, 2024
79b1122
fix: use Icrypto in place of Cypto
yemkareems Oct 28, 2024
3fd16de
fix: crypto made inline for constructor and decrypt error handled in …
yemkareems Oct 28, 2024
34b07ac
fix: crypto made inline for constructor and decrypt error handled in …
yemkareems Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: crypto made inline for constructor and decrypt error handled in … 
…exception

Signed-off-by: yemkareems <[email protected]>
  • Loading branch information
@yemkareems
yemkareems committed Oct 28, 2024
commit 34b07ace9579db1ce04feebd1c15f626f5503ee3
6 changes: 4 additions & 2 deletions lib/private/Authentication/LoginCredentials/Store.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,12 @@ class Store implements IStore {
/** @var IProvider|null */
private $tokenProvider;

public function __construct(ISession $session,
public function __construct(
ISession $session,
LoggerInterface $logger,
private readonly ICrypto $crypto,
?IProvider $tokenProvider = null) {
?IProvider $tokenProvider = null,
) {
$this->session = $session;
$this->logger = $logger;
$this->tokenProvider = $tokenProvider;
Expand Down