fix(ShareApiController): Set hideDownload to inverse of allow download attribute #48987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d attribute If the download attribute is set to false, then we should set hideDownload to true (essentially hiding the download button from the UI) and vice versa Signed-off-by: fenn-cs <[email protected]>
nfebe
force-pushed
the
fix/46920/respect-no-download
branch
from
ed1b327 to
d9aa278
Compare
nfebe
added
2. developing
Contributor
Author
|
nextcloud/circles#1731 now comprehensively solves it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the download attribute is set to false, then we should set hideDownload to true (essentially hiding the download button from the UI) and vice versa
Resolves: #46920