Skip to content

Conversation

@joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Nov 5, 2024

  • Resolves: #

Summary

We already have handling for specifying a port at install time or later on (which work just fine). Yet we write out a bogus parameter dbport to the initial config.

This value is neither supported nor used (even at install time). Yet we save this bogus parameter in the initial config. Since it's in the config, people end up assuming it does something and wondering why it doesn't work.

It either ends up being:

        "dbport": "",

Or, if a specific port was explicitly specified via maintenance:install --database-port than that port ends up there. It gets populated with the correct value, but it's still not actually used so 🤷

        "dbport": "3306",

Let's not write it to the config at install time since it's a no-op and avoid all this confusion.

Additional historical context:

TODO

  • ...

Checklist

@joshtrichards joshtrichards added this to the Nextcloud 31 milestone Nov 5, 2024
@skjnldsv skjnldsv requested review from a team, Altahrim, nickvergessen, skjnldsv and sorbaugh and removed request for a team November 6, 2024 07:54
@joshtrichards joshtrichards added the papercut Annoying recurring UX issue with possibly simple fix. label Dec 30, 2024
@blizzz blizzz mentioned this pull request Jan 8, 2025
This was referenced Jan 14, 2025
This was referenced Jan 21, 2025
@blizzz blizzz mentioned this pull request Jan 29, 2025
1 task
@blizzz blizzz modified the milestones: Nextcloud 31, Nextcloud 32 Jan 29, 2025
@skjnldsv skjnldsv requested review from a team and ArtificialOwl and removed request for a team August 1, 2025 09:03
@skjnldsv skjnldsv enabled auto-merge August 1, 2025 09:03
@skjnldsv skjnldsv merged commit 5108b8f into master Aug 1, 2025
177 checks passed
@skjnldsv skjnldsv deleted the fix/install-dbport-unused branch August 1, 2025 09:35
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews feature: database Database related DB feature: install and update papercut Annoying recurring UX issue with possibly simple fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants