fix(theming): Return default theme if the user never selected a theme #49112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: provokateurin <[email protected]>
Member
Author
|
/backport to stable30 |
Member
Author
|
/backport to stable29 |
Member
Author
|
/backport to stable28 |
susnux
approved these changes
Nov 7, 2024
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Makes sense, also tested and works fine.
I am not 100% this is intended, because "default" is not a theme but just an alias to select either dark or light depending on user agent, so empty attribute still means "default".
skjnldsv
approved these changes
Nov 7, 2024
This was referenced Nov 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While working on nextcloud/ocs_api_viewer#36 I found that if the user never selected a theme the
data-themesattribute would only be an empty string instead of containing thedefaulttheme.I'm not sure if the fallback also needs to be changed in other places, but this at least fixes the attribute problem.
Checklist