Skip to content

[local] DNS: do not query CNAME if A succeeded already #49223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
artonge wants to merge 2 commits into from
Closed

[local] DNS: do not query CNAME if A succeeded already #49223

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
333f20d
fix: do not query CNAME if A succeeded already
georglauterbach Oct 13, 2024
02b1138
fix: remove superflous line
georglauterbach Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: remove superflous line 
Signed-off-by: georglauterbach <[email protected]>
  • Loading branch information
@georglauterbach @artonge
georglauterbach authored and artonge committed Nov 12, 2024
commit 02b1138079d27af977a3b6f80b944e4123a9a895
1 change: 0 additions & 1 deletion lib/private/Http/Client/DnsPinMiddleware.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ private function dnsResolve(string $target, int $recursionCount) : array {
$canHaveCnameRecord = false;
} elseif (isset($dnsResponse['target']) && $canHaveCnameRecord) {
$targetIps = array_merge($targetIps, $this->dnsResolve($dnsResponse['target'], $recursionCount));
$canHaveCnameRecord = true;
}
}
} elseif ($dnsNegativeTtl !== null) {
Expand Down
Loading