Skip to content

fx(dav): file request guest nickname encoding #49226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 2 commits into from
Nov 12, 2024
Merged

fx(dav): file request guest nickname encoding #49226

skjnldsv merged 2 commits into from
Nov 12, 2024

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 12, 2024

Fix #48942

Steps

  1. Create a file request
  2. Access the file request URI
  3. Enter a guest name with an umlaut Mörris
  4. Upload a file and see a 500 request

@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Nov 12, 2024
@skjnldsv skjnldsv requested review from a team and susnux November 12, 2024 11:47
@skjnldsv skjnldsv self-assigned this Nov 12, 2024
@skjnldsv skjnldsv requested review from Altahrim, Pytal, artonge and nfebe and removed request for a team November 12, 2024 11:47
@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 12, 2024

/backport to stable30

@skjnldsv skjnldsv force-pushed the fix/encode-guest-file-request branch 2 times, most recently from 75029a8 to 79e0e73 Compare November 12, 2024 11:55
susnux
susnux reviewed Nov 12, 2024
View reviewed changes
@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 12, 2024

/compile rebase

@skjnldsv skjnldsv enabled auto-merge November 12, 2024 22:32
@nextcloud-command nextcloud-command force-pushed the fix/encode-guest-file-request branch from 79e0e73 to 94d22a7 Compare November 12, 2024 22:41
@skjnldsv skjnldsv merged commit 034106d into master Nov 12, 2024
185 checks passed
@skjnldsv skjnldsv deleted the fix/encode-guest-file-request branch November 12, 2024 23:00
@backportbot backportbot bot mentioned this pull request Nov 12, 2024
Merged
2 tasks
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux left review comments

@Pytal Pytal Pytal approved these changes

@provokateurin provokateurin provokateurin approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-frontend

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@artonge artonge Awaiting requested review from artonge artonge is a code owner automatically assigned from nextcloud/server-backend

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews bug feature: dav feature: files

Projects

Files to vue
Status: Done

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

[Bug]: Upload Error with guest name containing umlaut in File Request

6 participants

@skjnldsv @susnux @Pytal @provokateurin @nextcloud-command