Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Nov 13, 2024

Backport of #48134

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added the 3. to review Waiting for reviews label Nov 13, 2024
@backportbot backportbot bot added this to the Nextcloud 30.0.3 milestone Nov 13, 2024
@SebastianKrupinski SebastianKrupinski marked this pull request as ready for review November 13, 2024 14:01
@miaulalala miaulalala removed their request for review November 13, 2024 15:44
return;
}

if ($event instanceof DeclarativeSettingsSetValueEvent) {

Check notice

Code scanning / Psalm

RedundantConditionGivenDocblockType Note

Docblock-defined type OCP\Settings\Events\DeclarativeSettingsSetValueEvent for $event is always OCP\Settings\Events\DeclarativeSettingsSetValueEvent
@kesselb kesselb added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Nov 14, 2024
@kesselb
Copy link
Contributor

kesselb commented Nov 14, 2024

Hi,

This is my usual approach for handling backports with conflicts:

gh pr checkout 49254 -f
git reset --hard HEAD~2
git clean -i
git cherry-pick 3e870695bc4989e5e2c6f59c44ed5dbd501a7673

and then resolve the conflicts one by one.

There was a lot of automated refactoring/reformatting meanwhile 🙈

@SebastianKrupinski
Copy link
Contributor

@kesselb Thank you, I was going to work on this today.

Signed-off-by: SebastianKrupinski <[email protected]>
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Nov 15, 2024
@st3iny st3iny merged commit 52f85a0 into stable30 Nov 15, 2024
171 checks passed
@st3iny st3iny deleted the backport/48134/stable30 branch November 15, 2024 06:59
@skjnldsv skjnldsv mentioned this pull request Nov 27, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants