Skip to content

[stable29] DNS: do not query CNAME if A succeeded already #49278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
come-nc merged 2 commits into from
Nov 14, 2024
Merged

[stable29] DNS: do not query CNAME if A succeeded already #49278

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
487d19a
fix: do not query CNAME if A succeeded already
georglauterbach Oct 13, 2024
c559f62
fix: remove superflous line
georglauterbach Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: remove superflous line 
Signed-off-by: georglauterbach <[email protected]>
  • Loading branch information
@georglauterbach @backportbot
georglauterbach authored and backportbot[bot] committed Nov 14, 2024
commit c559f62a36403dbbee6bf56e28af536c5747d5f2
1 change: 0 additions & 1 deletion lib/private/Http/Client/DnsPinMiddleware.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ private function dnsResolve(string $target, int $recursionCount) : array {
$canHaveCnameRecord = false;
} elseif (isset($dnsResponse['target']) && $canHaveCnameRecord) {
$targetIps = array_merge($targetIps, $this->dnsResolve($dnsResponse['target'], $recursionCount));
$canHaveCnameRecord = true;
}
}
} elseif ($dnsNegativeTtl !== null) {
Expand Down
Loading