feat(systemtags): add color support #49295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
added
enhancement
design
skjnldsv
force-pushed
the
feat/tags-colors
branch
from
887004b to
d7df8e8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
force-pushed
the
feat/systemtags-bulk-create-list
branch
from
51a2dff to
99a7346
Compare
skjnldsv
force-pushed
the
feat/tags-colors
branch
4 times, most recently
from
a0248a7 to
6bf50f7
Compare
skjnldsv
force-pushed
the
feat/tags-colors
branch
from
6bf50f7 to
c6afe55
Compare
jancborchardt
approved these changes
Nov 20, 2024
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Looks very very nice! I have no feedback. @marcoambrosini?
jancborchardt
previously requested changes
Nov 20, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
@jancborchardt There is also the inline tag display missing on this PR. I'll keep them like they are right now, no background and color the text+border only, following the WCAG contrast of course. Quick example (careful, contrast hasn't been calculated, this is just a mockup) |
skjnldsv
force-pushed
the
feat/tags-colors
branch
5 times, most recently
from
1f51a54 to
c6bd30d
Compare
skjnldsv
requested review from
a team,
artonge,
jancborchardt and
susnux
and removed request for
a team
marcelklehr
reviewed
Dec 5, 2024
artonge
approved these changes
Dec 5, 2024
skjnldsv
force-pushed
the
feat/tags-colors
branch
from
c6bd30d to
cd13290
Compare
marcelklehr
approved these changes
Dec 6, 2024
skjnldsv
force-pushed
the
feat/tags-colors
branch
from
cd13290 to
c745389
Compare
skjnldsv
added
4. to release
skjnldsv
force-pushed
the
feat/tags-colors
branch
from
c745389 to
d802ead
Compare
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
skjnldsv
force-pushed
the
feat/tags-colors
branch
from
d802ead to
99a4f5a
Compare
Signed-off-by: skjnldsv <[email protected]>
skjnldsv
force-pushed
the
feat/tags-colors
branch
from
99a4f5a to
885b692
Compare
2 tasks
|
Thanks a lot for this. What is the planend release Version? |
Member
|
@disaster123 Nextcloud 31 Hub 10 |
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6778
WIP
In progress
Screenshot