Skip to content

[stable30] fix(files): Restore page title (folder - view - product) #49419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 3 commits into from
Nov 21, 2024
Merged

[stable30] fix(files): Restore page title (folder - view - product) #49419

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2fed7bc
fix(files): Restore page title (folder - view - product)
susnux Nov 19, 2024
5a99efe
chore(assets): Recompile assets
nextcloud-command Nov 21, 2024
9647bb5
chore(assets): Recompile assets
nextcloud-command Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(files): Restore page title (folder - view - product) 
* Folder: Current folder if not root
* View: Name of current view
* Product: Nextcloud

Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux @nextcloud-command
susnux authored and nextcloud-command committed Nov 21, 2024
commit 2fed7bcf82df5ccaee83745ec379b573df962a70
14 changes: 13 additions & 1 deletion apps/files/src/views/FilesList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,12 @@ export default defineComponent({
},

pageHeading(): string {
return this.currentView?.name ?? t('files', 'Files')
const title = this.currentView?.name ?? t('files', 'Files')

if (this.currentFolder === undefined || this.directory === '/') {
return title
}
return `${this.currentFolder.displayname} - ${title}`
},

/**
Expand Down Expand Up @@ -426,6 +431,13 @@ export default defineComponent({
},

watch: {
/**
* Update the window title to match the page heading
*/
pageHeading() {
document.title = `${this.pageHeading} - ${getCapabilities().theming?.productName ?? 'Nextcloud'}`
},

/**
* Handle rendering the custom empty view
* @param show The current state if the custom empty view should be rendered
Expand Down