rename secure drop back to files drop #4943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@schiessle, thanks for your PR! By analyzing the history of the files in this pull request, we identified @blizzz, @rullzer and @ChristophWurst to be potential reviewers. |
schiessle
requested review from
MorrisJobke,
jancborchardt,
jospoortvliet and
rullzer
…securedrop.org Signed-off-by: Bjoern Schiessle <[email protected]>
schiessle
force-pushed
the
rename-secure-drop
branch
from
ca6a0a8 to
e9ab452
Compare
Member
|
Really? I thought we keep it? |
Member
Member
|
Until we have found a better name - or are at least sure to use "Secure Drop" we should stay at the old name - File Drop 😉 |
MorrisJobke
approved these changes
May 19, 2017
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
I'm fine with this. We used this in the past and it doesn't seems to cause confusions -> go for it
Member
|
Yes please, as talked about because we should not have it conflict with the SecureDrop project for whistleblowing - which in its core of uploading files is very similar. 👍 |
MariusBluem
approved these changes
May 19, 2017
Member
|
@schiessle Please open also a PR against stable12 |
juliusknorr
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename secure drop back to files drop because of name collision with securedrop.org
fix #4674