Skip to content

fix(SetupChecks): Pass webfinger if the handler returns 400 too #49440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 1 commit into from
Jan 26, 2025
Merged

fix(SetupChecks): Pass webfinger if the handler returns 400 too #49440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(SetupChecks): Pass webfinger if a handler is there 
Signed-off-by: Josh <[email protected]>
  • Loading branch information
@joshtrichards @AndyScherzinger
joshtrichards authored and AndyScherzinger committed Jan 26, 2025
commit b452dc0697b949cf78ff499749e48e21c4ddfec6
2 changes: 1 addition & 1 deletion apps/settings/lib/SetupChecks/WellKnownUrls.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public function run(): SetupResult {
}

$urls = [
['get', '/.well-known/webfinger', [200, 404], true],
['get', '/.well-known/webfinger', [200, 400, 404], true], // 400 indicates a handler is installed but (correctly) failed because we didn't specify a resource
['get', '/.well-known/nodeinfo', [200, 404], true],
['propfind', '/.well-known/caldav', [207], false],
['propfind', '/.well-known/carddav', [207], false],
Expand Down
Loading