[stable28] fix(external_storage): Cast id to int #49466
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
requested review from
come-nc,
marcelklehr and
provokateurin
Member
|
@marcelklehr keep or close? |
Member
|
Keep. Still needs fixing |
marcelklehr
approved these changes
Dec 6, 2024
oleksandr-nc
approved these changes
Dec 6, 2024
blizzz
force-pushed
the
backport/49464/stable28
branch
from
865b148 to
ed895e2
Compare
blizzz
requested changes
Dec 6, 2024
Member
blizzz
left a comment
blizzz
left a comment
There was a problem hiding this comment.
Blocking as 28 is de facto EOL
Member
|
lol, alright then. |
AndyScherzinger
force-pushed
the
backport/49464/stable28
branch
from
ed895e2 to
13c1343
Compare
Member
|
Closed and re-opened. Keep or sweep @marcelklehr @blizzz ? |
Member
|
I don't know the background, @marcelklehr`s decision. |
follow up to #49218 Signed-off-by: Marcel Klehr <[email protected]> [skip ci]
Signed-off-by: Marcel Klehr <[email protected]>
AndyScherzinger
force-pushed
the
backport/49464/stable28
branch
from
13c1343 to
3b65c4c
Compare
Member
|
It's not a security issue. It came from a ticket that belonged to @oleksandr-nc: #49602 Closing for now as 28 is EOL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #49464
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.