[stable28] Bug/48678/restore dav error response #49482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
requested review from
ChristophWurst,
kesselb and
miaulalala
kesselb
force-pushed
the
backport/49004/stable28
branch
from
c7ada10 to
fde56d6
Compare
Contributor
|
Conflicts: Constructor property promotion and Imports in Server and ServerFactory, New integration test in caldav.feature |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $error->setAttribute('xmlns:s', self::NS_SABREDAV); | ||
| $DOM->appendChild($error); | ||
|
|
||
| $h = function ($v) { |
Check notice
Code scanning / Psalm
MissingClosureReturnType Note
| $error->setAttribute('xmlns:s', self::NS_SABREDAV); | ||
| $DOM->appendChild($error); | ||
|
|
||
| $h = function ($v) { |
Check notice
Code scanning / Psalm
MissingClosureParamType Note
| } | ||
| class BrowserErrorPagePlugin extends ServerPlugin { | ||
| /** @var Server */ | ||
| private $server; |
Check notice
Code scanning / Psalm
MissingConstructor Note
| $this->server->httpResponse->setHeader('Content-Type', 'application/xml; charset=utf-8'); | ||
| } | ||
| public function generateBody(int $httpCode) { | ||
| $request = \OC::$server->getRequest(); |
Check notice
Code scanning / Psalm
DeprecatedMethod Note
kesselb
force-pushed
the
backport/49004/stable28
branch
from
fde56d6 to
424a53a
Compare
miaulalala
approved these changes
Nov 26, 2024
solracsf
approved these changes
Nov 28, 2024
kesselb
force-pushed
the
backport/49004/stable28
branch
2 times, most recently
from
7cbc5ba to
ff57dc8
Compare
Merged
Member
|
@kesselb keep or close? |
4 tasks
kesselb
force-pushed
the
backport/49004/stable28
branch
from
ff57dc8 to
1eb1126
Compare
Member
|
Daniel wants to give this a final test, then we are good to merge |
…eption output" This reverts commit e202896. Signed-off-by: Daniel Kesselberg <[email protected]>
This reverts commit d2bf361. Signed-off-by: Daniel Kesselberg <[email protected]>
This reverts commit 9992e7d. Signed-off-by: Daniel Kesselberg <[email protected]>
Signed-off-by: Daniel Kesselberg <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
kesselb
force-pushed
the
backport/49004/stable28
branch
from
1eb1126 to
67b013b
Compare
kesselb
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #49004
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.