Skip to content

[stable30] fix(activity): Fix activity object type warnings #49522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Nov 27, 2024
Merged

[stable30] fix(activity): Fix activity object type warnings #49522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(activity): Fix activity object type warnings 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen @backportbot
nickvergessen authored and backportbot[bot] committed Nov 27, 2024
commit 916e050bb59de7a905017261c5e9771ecd37b2f7
6 changes: 3 additions & 3 deletions apps/settings/lib/Activity/Provider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,20 +142,20 @@ protected function getParameters(IEvent $event): array {
return [
'token' => [
'type' => 'highlight',
'id' => $event->getObjectId(),
'id' => (string)$event->getObjectId(),
'name' => $parameters['name'],
]
];
case self::APP_TOKEN_RENAMED:
return [
'token' => [
'type' => 'highlight',
'id' => $event->getObjectId(),
'id' => (string)$event->getObjectId(),
'name' => $parameters['name'],
],
'newToken' => [
'type' => 'highlight',
'id' => $event->getObjectId(),
'id' => (string)$event->getObjectId(),
'name' => $parameters['newName'],
]
];
Expand Down
2 changes: 1 addition & 1 deletion lib/public/TaskProcessing/ISynchronousProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ interface ISynchronousProvider extends IProvider {
* @param callable(float):bool $reportProgress Report the task progress. If this returns false, that means the task was cancelled and processing should be stopped.
* @psalm-return array<string, list<numeric|string>|numeric|string>
* @throws ProcessingException
*@since 30.0.0
* @since 30.0.0
*/
public function process(?string $userId, array $input, callable $reportProgress): array;
}
Loading